Explicitly define crop focus #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, I am satisfied with this now, just wanted to find a way to test metadata reading from asset meta files. It is a bit quirky, when you upload a file through the asset container class, it generates image presets for control panel images, which triggers metadata hydration. @riasvdv ready for you to check! |
|
Awesome! Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #126.
I will file a bug report to
statamic/cmsrepo too but meanwhile I think it does not hurt to generate URLs that explicitly define the crop focus. I think this is normal default behavior for images to be crop focused on this addon, if not they can override withglide:fitparam or thestatamic.assets.auto_cropconfig if they have not already.I will ping you Rias once the PR is marked ready. :)