Fix fieldtype Vue component issues #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncla
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From what I found, setting
this.value = value;seems redundant and the value updates, saves correctly with justthis.update(value);. Removing this line fixes the warning #155Adding
:trackDirtyState="false"fixes the dirty state part of the #120 issue. The issue was if you were to save an entry with "Go to listing" save option, it would unnecessarily, annoyingly trigger the "Reload site?" prompt. The dirty state tracking still works as thisResponsiveFieldtypecomponent is a child of anotherPublishContainercomponent which already has dirty state tracking. I assume wherever thisResponsiveFieldtypemight appear, a parent componentPublishContainerhas dirty state tracking anyway.