Don't write out of bounds [Fixes #9] #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
definelicht
changed the title
Closed
|
I would like to review and test this but unfortunately Vitis is broken because it is 2022 |
|
I added a verification script that runs through a bunch of different combinations. It passes in the simulation, so I'm good to merge this. We can check for perf regressions after the Xilinx tools get patched |
ChrisPattison
approved these changes
Jan 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this will negatively impact performance due to the branch. An alternative solution would be to have dynamically sized loop bounds depending on the tile, which could also negatively impact performance 🤔