Free Running Kernel #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…size of Xilinx DSP multiplications
| const PackedFloat b = (n1 == 0) ? b_read : b_buffer[m1]; | ||
| const PackedFloat c = (k == 0) ? c_read : c_buffer[n1 * kTileSizeM + m1]; | ||
| a_buffer = a; | ||
| b_buffer[m1] = b; | ||
| // Ignore contributions from out-of-bound indices | ||
| const bool in_bounds = (n0 * kTileSizeN + n1 < size_n) && (m0 * kTileSizeM + m1 < size_m); | ||
| // Meat of the computation | ||
| const auto res = in_bounds ? MultiplyAccumulate(a, b, c) : c; |
There was a problem hiding this comment.
Somewhat of a micro-optimization but it would probably be better to pass 0 into the MAC instead of bypassing the MAC completely. So like
MultiplyAccumulate(in_bounds ? a : 0, in_bounds ? b : 0, c) : c;
That way we don't need a bunch of registers that have to bypass the multiplier
ChrisPattison
requested changes
Dec 22, 2021
| } | ||
| const PackedFloat a_read = a_in.Pop(); | ||
| const PackedFloat b_read = b_in.Pop(); | ||
| const PackedFloat c_read = c_in.Pop(); |
There was a problem hiding this comment.
Does this work if you're on an out of bounds index? It seems like it might desynchronize where you are in the matrix multiply vs where you're pulling data from
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
Random.cpp