Support for __array_interface__
#1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 27, 2022 16:23
Co-authored-by: Tal Ben-Nun <tbennun@users.noreply.github.com>
Co-authored-by: Tal Ben-Nun <tbennun@users.noreply.github.com>
Co-authored-by: Tal Ben-Nun <tbennun@users.noreply.github.com>
…StorageType.Default
tbennun
approved these changes
Jul 28, 2022
orausch
added a commit
that referenced
this pull request
Jul 31, 2022
PR #1071 introduced a regression here for torch tensors, since for them, ``is_array`` is true, but ``__array_interface__`` doesn't exist.
alexander-hammett
pushed a commit
to alexander-hammett/dace
that referenced
this pull request
Sep 20, 2022
alexander-hammett
pushed a commit
to alexander-hammett/dace
that referenced
this pull request
Sep 20, 2022
PR spcl#1071 introduced a regression here for torch tensors, since for them, ``is_array`` is true, but ``__array_interface__`` doesn't exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements support for objects implementing the
__array_interface__similar to the already supported__cuda_array_interface__