Set storage type for torch tensors when creating data descriptors #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the storage of torch tensors was ignored
PR #1071 introduced a regression here for torch tensors, since for them, ``is_array`` is true, but ``__array_interface__`` doesn't exist.
tbennun
reviewed
Jul 31, 2022
| @@ -33,7 +33,7 @@ def create_datadescriptor(obj, no_custom_desc=False): | |||
| return obj.__descriptor__() | |||
| elif not no_custom_desc and hasattr(obj, 'descriptor'): | |||
| return obj.descriptor | |||
| elif dtypes.is_array(obj): | |||
| elif dtypes.is_array(obj) and (hasattr(obj, '__array_interface__') or hasattr(obj, '__cuda_array_interface__')): | |||
There was a problem hiding this comment.
What regression does this cause?
There was a problem hiding this comment.
For torch tensors is_array is true, but __array_interface__ doesn't exist. Thus this branch gets chosen but it fails later when __array_interface__ is accessed.
tbennun
approved these changes
Jul 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the storage of torch tensors was ignored. Also fixes a regression introduced in #1071.