Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes and extended testing for Fortran SUM #1390

Merged
merged 10 commits into from Oct 20, 2023
Merged

Conversation

mcopik
Copy link
Contributor

@mcopik mcopik commented Oct 12, 2023

This PR addresses some of the issues raised in #1368:

  • Fix bug in missing variable declaration for SUM.
  • Support SUM(arr)
  • Support SUM over arrays with offset normalization
  • Fix handling of 2D arrays with SUM.

It also adds more test cases to catch all edge cases for ArrayToLoop and SumToLoop transformations.

@acalotoiu

@mcopik mcopik changed the title Bugfixes and extended testing for Fortan SUM Bugfixes and extended testing for Fortran SUM Oct 12, 2023
Copy link
Contributor

@acalotoiu acalotoiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you

@acalotoiu acalotoiu enabled auto-merge (squash) October 19, 2023 14:25
@acalotoiu acalotoiu merged commit af62440 into master Oct 20, 2023
9 checks passed
@mcopik mcopik deleted the fortran_sum_bug branch November 6, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants