Implement loop-based Fortran intrinsics #1394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
…eturn type of intrinsic
…ry operations with an array
|
@acalotoiu Please review - all of the loop-based intrinsic should now be ready. We also need to merge #1390 before this one. |
acalotoiu
requested changes
Nov 2, 2023
|
@acalotoiu Merge conflict is now resolved. It's ready to merge once tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contributes the missing intrinsic to the Fortran frontend that requires a loop-based implementation. Furthermore, it also reorganizes the implementation of existing intrinsics, moves to a separate module, increases code reuse, and adds more tests.
This PR depends on #1390 - it needs to be merged first.
Intrinsics: