Issue 197. Fix handling of optional package fields #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your editor reformatted much of the changed files. Could you make the changes without the changes to the white space? FYI - We're using the default Eclipse 2.1 formatter which is set to tabs only, tab size of 4. |
|
updating |
|
Restored the surrounding formatting, please take another look |
goneall
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
Thanks @AlexanderYukhanov
I'll merge this in for the next release.
| @@ -606,19 +603,13 @@ protected List<String> _verify(Set<String> verifiedIds, String specVersion) { | |||
|
|
|||
| // files depends on if the filesAnalyzed flag | |||
| try { | |||
| if (getFiles().size() == 0) { | |||
| if (filesAnalyzed) { | |||
There was a problem hiding this comment.
I noticed we removed the check for files being present when files analyzed is true.
I went back and read the spec, and indeed there is no stated requirement that files be present - so this change is correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.