Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New license request: 3D-Slicer-1.0 #2213

Closed
jcfr opened this issue Oct 17, 2023 · 13 comments · Fixed by #2476
Closed

New license request: 3D-Slicer-1.0 #2213

jcfr opened this issue Oct 17, 2023 · 13 comments · Fixed by #2476

Comments

@jcfr
Copy link

jcfr commented Oct 17, 2023

1. License Name: 3D Slicer license

2. Short identifier: 3d-slicer-license

3. License Author or steward: Brigham and Women’s Hospital (BWH)

4. Comments:

The 3D Slicer software is distributed under a BSD-style open source license that is broadly compatible with the Open Source Definition by The Open Source Initiative and contains no restrictions on legal uses of the software.

Historical notes about the license

See https://slicer.readthedocs.io/en/latest/user_guide/about.html#historical-notes-about-the-license

License terms and reasons

See https://slicer.readthedocs.io/en/latest/user_guide/about.html#license-terms-and-reasons

Status compared to other open source licenses

As of June 2021, the Slicer License has been used for over 15 years without incident. In May of 2021, a discourse user suggested submitting the license to the OSI license review process. After some discussion and hearing no objections, the community leadership decided to submit the license for review. Although the OSI process is not legally binding, the discussion could give potential Slicer users perspective on how provisions of the license compare with other commonly used licenses. The discussion concluded that bundling the contribution agreement in the license makes it non-approvable by OSI and the requirement to use the software for legal purposes may not be consistent with the Open Source Definition. Otherwise the license terms appear not to be controversial. Interested parties should review the full discussion for details.

Copied from https://slicer.readthedocs.io/en/latest/user_guide/about.html#status-compared-to-other-open-source-licenses

5. License Request Url: http://tools.spdx.org/app/license_requests/312

6. URL(s):

7. OSI Status: Rejected

8. Example Projects:

@jlovejoy jlovejoy added this to the 3.23 milestone Oct 23, 2023
@swinslow swinslow self-assigned this Dec 14, 2023
@swinslow
Copy link
Member

Discussed briefly on 2023-12-14 legal team call, @swinslow to review in detail and provide full analysis for consideration

@jcfr
Copy link
Author

jcfr commented Dec 14, 2023

Thanks for follow-up 🙏

In the meantime, let us know if you you have any questions.

cc: @lassoan @pieper @sjh26

@jlovejoy jlovejoy modified the milestones: 3.23, 3.24 Feb 7, 2024
@jlovejoy
Copy link
Member

jlovejoy commented Feb 15, 2024

New submission review

  • Has the license been approved by the OSI?
    • Yes
    • No - it was submitted to OSI, some issues raised, and then submission was rescinded

Definitive Factors

These must all be satisfied to allow inclusion in the license list

  1. Is the submitted license unique, that is, it does not match another license already on the License List as per the matching guidelines?
    • Yes
    • No
  2. If a software license, does it apply to source code and not only to executables?
    • Yes
    • No
  3. Does the license have identifiable and stable text, and is not in the midst of drafting?
    • Yes
    • No
  4. Has the license steward, if any, committed to versioning new versions and to not modify it after addition to the list?
    • I believe so

Other factors for inclusion

Roughly in order of descending importance

  1. Does the license substantially comply with one of the free/open content definitions? (examples include the Open Source Definition and the Debian Free Software Guidelines)
    • the license part B seems to, but it also includes in part A a contributor license, which is simply unusual
  2. Is the license structured to be generally usable by anyone, and not specific to one organisation or project?
    • Yes
    • No - it is very much specific to the project and project maintainer
  3. Does the license have substantial use such that it is likely to be encountered (ie. use in many projects, or in one significant project)?
  4. Is the license primarily intended to facilitate the free distribution of content with limited restrictions?
    • Yes, but it is very, very specific to the code, type of code (has clauses related to medical software), and project maintainers
  5. Does the license steward support this submission, or is at least aware of and not in opposition of it?
    • I believe so

Summary of factors, outcome, comments

Although I'm a bit stuck on the specificity of the license and that it's been around for some time (since 2005) and no one has yet submitted it (I've never come across it myself, but that's just me). At the same time, if the download history can be considered significant and it is likely to be found in the software supply chain, then I'd think it is viable to add. I'm just not clear on this last part.
I'd like to get some other thoughts from the SPDX-legal community

@pieper
Copy link

pieper commented Feb 15, 2024

Thank you for the review. Let us know if there are any specifics we can help resolve.

@karsten-klein
Copy link

karsten-klein commented Feb 23, 2024

ScanCode
identifier: 3dslicer-1.0

metaeffekt universe
canonical name: 3D Slicer Contribution and Software License Agreement 1.0
short identifier: 3D-Slicer-1.0 (we preserve original case)

Others:
I would not include the "-license" on the short name. This is until now done very rarely (some exceptional BSD cases). The predominant convention - as it appears to me - is not to include a "-license" suffix on shortId.

@jcfr
Copy link
Author

jcfr commented Feb 23, 2024

Thanks for taking the time to comment and provide references 🙏

Being consistent with existing best practices and conventions makes sense. I definitely support the proposed naming 👌


Explicitly specifying 1.0 is indeed sensible considering the version is explicitly mentioned in the license text 💯

@jlovejoy
Copy link
Member

Thanks @karsten-klein for the input on naming!

Do you have any insight as to the "substantial use" factor? (see my comment above)

@karsten-klein
Copy link

I'm afraid, I don't have any substantial information on the use of the license.

@jcfr
Copy link
Author

jcfr commented Mar 26, 2024

Do you have any insight as to the "substantial use" factor?

Over the past decade, the project has been downloaded more than 1.5 million times1, with over 270,000 downloads in just the past year alone. Moreover, Slicer was used in more than 17,000 peer reviewed publications2. Beyond its academic and research applications, the software also serves as the foundation for various commercial applications, including FDA-approved ones3.

It may also be worth noting that the license was developed by Harvard Medical School in the context of collaborative NIH-funded research involving 15 institutions, including MIT, GE, UNC, and other commercial and academic organizations. All parties involved carefully reviewed and signed off on the license. Subsequent reviews by other organizations have supported ongoing growth of the community.

Thanks again for your time reviewing our submission 🙏.

In the meantime, let us know if you have any additional questions. Also, if you think that would be helpful, we have a weekly4 public video hangout with users and developers of the medical imaging community and we would welcome the opportunity to engage further in discussions there.

Reply co-authored by @pieper, @lassoan and @jcfr in the context of the Slicer weekly community meeting of March 26th.

Footnotes

  1. https://download.slicer.org/download-stats/

  2. https://scholar.google.com/scholar?hl=en&as_sdt=1%2C22&as_vis=1&q=%28%223D+Slicer%22+OR+%22slicer+software%22+OR+%22slicer+org%22+OR+Slicer3D%29+-Slic3r+&btnG=

  3. https://www.slicer.org/commercial-use.html

  4. Weekly at 10am ET, announced at https://discourse.slicer.org/c/community/hangout/20

@swinslow
Copy link
Member

swinslow commented May 9, 2024

Thank you all for your comments (and my apologies for not getting to the writeup -- thanks very much @jlovejoy for the analysis above).

Given @jlovejoy's review, and the details from @jcfr regarding usage, I'm also +1 to add this to the list. Per @karsten-klein's note I agree that it shouldn't include '-license' as the suffix to the identifier. Discussed on 2024-05-09 legal team call and agreed to add with 3D-Slicer-1.0 as the identifier, given the 1.0 version number in the license text.

@swinslow swinslow changed the title New license request: 3d-slicer-license [SPDX-Online-Tools] New license request: 3d-Slicer-1.0 May 9, 2024
@swinslow
Copy link
Member

swinslow commented May 9, 2024

License Inclusion Decision

Decision:

  • approved
  • not approved

Name

3D Slicer License

License ID

3D-Slicer-1.0

XML markup

None

Notes

Likely none, will confirm during XML submission

Next steps

@swinslow to add if no one else does prior to the 3.24 release

@swinslow swinslow self-assigned this May 9, 2024
@swinslow swinslow changed the title New license request: 3d-Slicer-1.0 New license request: 3D-Slicer-1.0 May 9, 2024
@swinslow
Copy link
Member

@jcfr Purely as a heads-up, in the course of putting together the PR to add this (#2476) I noticed that there are a couple of typo differences between the license text at https://github.com/Slicer/Slicer/blob/main/License.txt, and the version from the Slicer website at https://slicer.org/LICENSE:

  1. In Part A.6, the GitHub version has the word "REQUIRES" where the Slicer website version has "REQURES"
  2. In Part B.1, the GitHub version has the word "Women's" where the Slicer website version has "Women?s". (I checked the bytes and it does actually appear to be a question mark / hex $3F, not some other weird Unicode character being rendered strangely.)

In #2476 I've included "alt text" regexes which should match to either of these, for SPDX matching purposes. But just mentioning in case the Slicer project decides that it wants to address these typos in the LICENSE version at https://slicer.org/LICENSE :)

Let me know if you have any questions, thanks!

Copy link

This new license/exception request has been accepted and the information for the license/exception has been merged to the repository. Thank you to everyone who has participated!
The license/exception will be published at https://spdx.org/licenses/ as part of the next SPDX License List release, which is expected to be in three months' time or sooner. In the interim, the new license will appear on the license list preview site at https://spdx.github.io/license-list-data/.
This is an automated message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants