-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 0BSD.xml #1246
Update 0BSD.xml #1246
Conversation
replace copyright holder with placeholder
as per the SPDX Matching Guidelines, the copyright notice for the software is considered replaceable - meaning, if there is a different name, it does not make it a different license. #738 was regressed b/c the variable markup is not needed due to the matching guidelines broader rule and tag I'm not sure what you mean by "some software may (incorrectly?) consume the license file" ? |
For example, Gitea uses the SPDX database as the source of licenses. A user selects a license for their repo and then the software pulls it in from SPDX. I was working on a project and checked the license which was used 0BSD but the copyright was "Rob Landley", this caused quite a bit of confusion as no one knew Rob Landley nor understood his relationship to the project. This has occurred to others (go-gitea/gitea#5397 was the root issue for #738) |
@yearski - thanks for that explanation! Just as a follow-up and curiosity - so, then would a Gitea user than be able to update/change the copyright notice to the right name? Because having just "author" still wouldn't be correct. Either way, the Gitea user still needs to update the copyright notice to their own name. Thinking about this - one thing to consider would be for Gitea to pull from the XML files and then ignore the tag. @seabass-labrax is looking into this more and will comment over there. I also want to check / confirm with @landley that this is, indeed, intended to be the copyright notice for the software and not the license itself (I've assumed the former, but if it's the latter, this would change my comment re: matching guidelines!) |
Correct. The issue for our project was confirming that Rob Landley was not a copyright holder and could be safely deleted; if instead the license had
Agreed, but given go-gitea/gitea#5397 it's seems that the Gitea team wants to simply copy the text from the source, which is why my proposed patch makes the license text of 0BSD consistent with other licenses here (BSD-2 and MIT for example) |
I think this gets back to the observation I made that we should have GENERIC copyright statements in the license that are obvious how to fill in (eg from the copyright just above/below the SPDX-License-Identifier: line). Many of the BSD licenses have this issue as well. It gets back to my quest as well for 'how does one know what license one is agreeing to when one sees:
and who would one go to if one needed to litigate something about license compliance? If the copyrights are all generic, like in the GPL-family, then it's obvious. If there's specific names filled into the templates, then it's less clear (common sense says those names are replaced, literal reading says they aren't: this could be a dispute due to the ambiguity). So I'd be in favor of merging it. |
👍 I'd repeat the same comment I made at #1224 (comment) |
Yes, the (suggested) copyright notice line is for the material being copyrighted, not for the license text itself. It's nice to know who is licensing the material, and how to contact them. |
FYI when I first submitted 0BSD to SPDX in 2015, I had "your name here" in the license text: https://lists.linux-foundation.org/pipermail/spdx-legal/2015-June/001443.html Alas, SPDX's approval cut and pasted the license text from https://landley.net/toybox/license.html and github pulled it in from their database. |
thanks all for the comments and @yearski - great to hear about another use of the SPDX License List! |
this failed due to lack of .txt file - so, I just went ahead and made a new PR that passed checks as that was easier (for me) |
Replace year and copyright holder specific example with placeholder. This method is consistent with BSD-2 and MIT files.
The root issue is that some software may (incorrectly?) consume the license file and generate a license citing Rob Landley, causing confusion. This has come up before, #737 for example. It was addressed by #738, but regressed by c6ac6f1.