Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add three new templated OpenSSL exceptions #824

Closed
wants to merge 1 commit into from

Conversation

swinslow
Copy link
Member

This commit addresses issue #720 by adding templated versions of
three different variants of OpenSSL exceptions found in the wild.
It allows these variants to be used with different licensors and
with different underlying licenses. It does not modify existing
openvpn-openssl-exception, which is specific to OpenVPN and GPLv2.

Fixes #720

Signed-off-by: Steve Winslow swinslow@gmail.com

This commit addresses issue spdx#720 by adding templated versions of
three different variants of OpenSSL exceptions found in the wild.
It allows these variants to be used with different licensors and
with different underlying licenses. It does not modify existing
openvpn-openssl-exception, which is specific to OpenVPN and GPLv2.

Signed-off-by: Steve Winslow <swinslow@gmail.com>
@jlovejoy
Copy link
Member

just read thread in #720 - I'm a little lost in terms of if this is ready to merge for 3.5
is the naming vetted for these? Also seems like using some capitalization would be helpful and consistent perhaps?
e.g. MongoDB-OpenSSL-exception
(although doesn't look like we did that for the existing OpenSSL exception, sigh)

@swinslow as you and @silverhook have been following this, I'll let you merge when it's ready or say otherwise if you need more input

@swinslow
Copy link
Member Author

@jlovejoy Prior legal team discussions had suggested things were aligned on these four exceptions, bu given the comments in #720 it looks like discussion is continuing which may make some parts of this unnecessary. So this may not yet be ready for 3.5. I suggest we move it to 3.6 and I'll aim to close it out early in the release cycle.

@jlovejoy
Copy link
Member

@swinslow - agree re: discussion continuing and to give that some more time

@swinslow
Copy link
Member Author

Per separate conversations on prior legal team call, this one needs some more work. I'm moving it from 3.6 to 3.7 and removing the "Accepted" tag, given the subsequent discussion in the issues thread.

@swinslow
Copy link
Member Author

Closing this, in favor of the analysis that will be happening in #1356 -- we can pull bits of this PR back out if it turns out to be useful.

@swinslow swinslow closed this Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Exception Request: OpenSSL Exception
2 participants