Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add html output #102

Merged
merged 3 commits into from
Mar 23, 2023
Merged

Add html output #102

merged 3 commits into from
Mar 23, 2023

Conversation

jspeed-meyers
Copy link
Collaborator

Fix #85

This is HTML output that is designed to be more aesthetically pleasing for spdx-online-tools. All feedback welcome. I'm a novice when it comes to HTML and web applications :)

Signed-off-by: John Speed Meyers <jsmeyers@chainguard.dev>
Modify the CLI to accept an HTML output and create a method
to return HTML output in a table format.

Signed-off-by: John Speed Meyers <jsmeyers@chainguard.dev>
@jspeed-meyers jspeed-meyers added the enhancement New feature or request label Mar 21, 2023
@jspeed-meyers jspeed-meyers self-assigned this Mar 21, 2023
Signed-off-by: John Speed Meyers <jsmeyers@chainguard.dev>
Copy link
Collaborator

@yong-aan yong-aan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, @jspeed-meyers!

@jspeed-meyers
Copy link
Collaborator Author

Thanks, @linynjosh!

@jspeed-meyers
Copy link
Collaborator Author

@goneall, any thoughts? We can always merge and improve later :)

Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @jspeed-meyers

@jspeed-meyers
Copy link
Collaborator Author

Thanks, @goneall!

@jspeed-meyers jspeed-meyers merged commit 30ad4c4 into spdx:main Mar 23, 2023
@jspeed-meyers jspeed-meyers deleted the add-html-output branch March 23, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Output Printing Style Better Suited for SPDX-Online-Tools
3 participants