Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement trusted publishing workflow #117

Merged
merged 1 commit into from
Apr 23, 2023

Conversation

jspeed-meyers
Copy link
Collaborator

See: https://docs.pypi.org/trusted-publishers/

For a summary of benefits, the link above mentions:

This confers significant usability and security advantages when compared to PyPI's traditional authentication methods:

Usability: with trusted publishing, users no longer need to manually create API tokens on PyPI and copy-paste them into their CI provider. The only manual step is configuring the publisher on PyPI.

Security: PyPI's normal API tokens are long-lived, meaning that an attacker who compromises a package's release can use it until its legitimate user notices and manually revokes it. Similarly, uploading with a password means that an attacker can upload to any project associated with the account. Trusted publishing avoids both of these problems: the tokens minted expire automatically, and are scoped down to only the packages that they're authorized to upload to.

See: https://docs.pypi.org/trusted-publishers/

For a summary of benefits, the link above mentions:

This confers significant usability and security advantages when compared to PyPI's traditional authentication methods:

>Usability: with trusted publishing, users no longer need to manually create API tokens on PyPI and copy-paste them into their CI provider. The only manual step is configuring the publisher on PyPI.

>Security: PyPI's normal API tokens are long-lived, meaning that an attacker who compromises a package's release can use it until its legitimate user notices and manually revokes it. Similarly, uploading with a password means that an attacker can upload to any project associated with the account. Trusted publishing avoids both of these problems: the tokens minted expire automatically, and are scoped down to only the packages that they're authorized to upload to.
@jspeed-meyers jspeed-meyers added enhancement New feature or request P2 Low priority security labels Apr 22, 2023
@jspeed-meyers jspeed-meyers self-assigned this Apr 22, 2023
@jspeed-meyers
Copy link
Collaborator Author

Huh, why is the build failing? Strange. The broken build seems unrelated to this change. :(

Copy link
Collaborator

@yong-aan yong-aan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jspeed-meyers!

@jspeed-meyers jspeed-meyers merged commit 2d29594 into main Apr 23, 2023
5 of 6 checks passed
@jspeed-meyers jspeed-meyers deleted the implement-trusted-publishing-workflow branch April 23, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2 Low priority security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants