implement --skip-validation flag #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumjjb
force-pushed
the
add-skip-validation
branch
from
1c14735
to
e24d228
Compare
Signed-off-by: Brandon Lum <lumjjb@gmail.com>
lumjjb
force-pushed
the
add-skip-validation
branch
from
e24d228
to
dd2ca10
Compare
|
@jspeed-meyers should be all good now! |
jspeed-meyers
approved these changes
Aug 2, 2023
There was a problem hiding this comment.
LGTM. @goneall or @linynjosh, can you please take a look too?
|
Merging :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SPDX validation takes a long time today (due to spdx/tools-python#742). This results in really long runtimes for larger SBOMs, around > 3MB.
This PR suggests an addition to
--skip-validationflag which will skip the validation step, which is not part of the NTIA conformance.