Fix file argument #154
Merged
Fix file argument #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maciej <mwkm00@gmail.com>
Signed-off-by: Maciej <mwkm00@gmail.com>
|
Thank you, @mwkm00! |
|
@mwkm00, it looks like the More info on black is here: https://github.com/psf/black Would you mind fixing that before I review this? |
Signed-off-by: Maciej <mwkm00@gmail.com>
|
Should be good now, I assumed exit code 1 would be acceptable after not delivering file arg, but the program goes to the help message and exits gracefully so exit code 0 is probably the way to go. Tests should be fixed now. |
jspeed-meyers
approved these changes
Sep 11, 2023
|
But the |
|
My bad, formatting. Thanks for patience. |
|
@vargenau, is that you were thinking? |
|
Hi, Yes, it works correctly now. Thank you for the quick fix. |
|
@goneall, would you please take a quick look too? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix should allow omitting --file argument (prints the help message if so), while still allowing to pass arguments like --verbose or --version without crashing.