Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support for -v shorthand for --verbose #156

Merged
merged 2 commits into from
Sep 12, 2023
Merged

support for -v shorthand for --verbose #156

merged 2 commits into from
Sep 12, 2023

Conversation

devbysn
Copy link
Contributor

@devbysn devbysn commented Sep 12, 2023

  1. added shorthand (-v) for --verbose flag
  2. added missing -h in documentation.

@jspeed-meyers jspeed-meyers added bug Something isn't working documentation Improvements or additions to documentation labels Sep 12, 2023
@jspeed-meyers jspeed-meyers linked an issue Sep 12, 2023 that may be closed by this pull request
Syntax of the short arguments #155
Closed
@jspeed-meyers
Copy link
Collaborator

@devbysn, it looks like the black formatting linter is failing.

More info on black is here: https://github.com/psf/black

Would you mind fixing this before I approve it? Otherwise, it looks good. Thank you!

cc @vargenau

@devbysn
Copy link
Contributor Author

devbysn commented Sep 12, 2023

hey,

i've checked with black linter, everything is find now.
can you verify?

@devbysn
Copy link
Contributor Author

devbysn commented Sep 12, 2023

I'm new to OS ecosystem.
i hope i'm not missing something @jspeed-meyers ;)

@jspeed-meyers
Copy link
Collaborator

@devbysn, LGTM! Thank you.

@jspeed-meyers
Copy link
Collaborator

@goneall or @linynjosh, would you PTAL too?

goneall
goneall requested changes Sep 12, 2023
View reviewed changes
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jspeed-meyers jspeed-meyers merged commit cbafec7 into spdx:main Sep 12, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goneall goneall goneall approved these changes

@jspeed-meyers jspeed-meyers Awaiting requested review from jspeed-meyers

@yong-aan yong-aan Awaiting requested review from yong-aan

Assignees

@devbysn devbysn

Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Syntax of the short arguments
3 participants
@devbysn @jspeed-meyers @goneall