Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace setup.py with pyproject.toml #47

Merged
merged 2 commits into from
Jan 17, 2023
Merged

Replace setup.py with pyproject.toml #47

merged 2 commits into from
Jan 17, 2023

Conversation

jspeed-meyers
Copy link
Collaborator

Fix #40

Signed-off-by: John Speed Meyers jsmeyers@chainguard.dev

@jspeed-meyers
Replace setup.py with pyproject.toml
1b23e97 
Signed-off-by: John Speed Meyers <jsmeyers@chainguard.dev>
@jspeed-meyers jspeed-meyers added the enhancement New feature or request label Jan 17, 2023
@jspeed-meyers jspeed-meyers self-assigned this Jan 17, 2023
@jspeed-meyers
Add blank line to pyproject.toml
68c1e3e 
Signed-off-by: John Speed Meyers <jsmeyers@chainguard.dev>
@jspeed-meyers jspeed-meyers marked this pull request as draft January 17, 2023 01:27
itsyongan
itsyongan approved these changes Jan 17, 2023
View reviewed changes
Copy link
Collaborator

@itsyongan itsyongan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@jspeed-meyers jspeed-meyers marked this pull request as ready for review January 17, 2023 13:39
@jspeed-meyers
Copy link
Collaborator Author

Thank you, @linynjosh!

@jspeed-meyers jspeed-meyers merged commit caa2015 into spdx:main Jan 17, 2023
@jspeed-meyers jspeed-meyers deleted the replace_setup_dot_py branch January 17, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsyongan itsyongan itsyongan approved these changes

Assignees

@jspeed-meyers jspeed-meyers

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace Setup.py With Pyproject.toml and Ensure Correct spdx-tools Dependency Specified
2 participants
@jspeed-meyers @itsyongan