Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #74

Merged
merged 2 commits into from
Feb 11, 2023
Merged

Update dependencies #74

merged 2 commits into from
Feb 11, 2023

Conversation

jspeed-meyers
Copy link
Collaborator

@jspeed-meyers jspeed-meyers commented Feb 9, 2023

Add click, which the CLI requires, and update the spdx-tools version in both the pipfile and pyproject.toml

(Dear internet: Does anyone know why the dependencies get listed twice, once in pyproject.toml and once in the pipfile? That's confusing to me.)

Signed-off-by: John Speed Meyers jsmeyers@chainguard.dev

Add click, which the CLI requires, and update the spdx-tools
version.

Signed-off-by: John Speed Meyers <jsmeyers@chainguard.dev>
Signed-off-by: John Speed Meyers <jsmeyers@chainguard.dev>
@jspeed-meyers jspeed-meyers added the enhancement New feature or request label Feb 9, 2023
@jspeed-meyers jspeed-meyers self-assigned this Feb 9, 2023
@github-actions
Copy link

github-actions bot commented Feb 9, 2023

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
252 221 88% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: ec93512 by action🐍

@anthonyharrison
Copy link
Contributor

@jspeed-meyers There are multiple ways of building Python applications. pyproject.toml is just one way of doing it.

i don't think you need Pipfile and Pipfile.lock as they are related to pipenv. (the lock file should be autogenerated - pipenv lock

@jspeed-meyers
Copy link
Collaborator Author

@anthonyharrison, this is helpful. Thank you.

Does pipenv know find pyproject.toml automagically? If the pipfile and pipfile.lock are removed from the codebase, does the GitHub action that does the build for testing need to be rewritten?

For instance:

@jspeed-meyers
Copy link
Collaborator Author

Thank you, @linynjosh

@jspeed-meyers jspeed-meyers merged commit 74d3ffd into main Feb 11, 2023
@jspeed-meyers jspeed-meyers deleted the update_dependencies branch February 11, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants