Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace click with argparse #81

Merged
merged 5 commits into from
Feb 13, 2023
Merged

Replace click with argparse #81

merged 5 commits into from
Feb 13, 2023

Conversation

jspeed-meyers
Copy link
Collaborator

Fix #78

Remove dependency on click and replace with argparse

Signed-off-by: John Speed Meyers jsmeyers@chainguard.dev

Remove dependency on click and replace with argparse

Signed-off-by: John Speed Meyers <jsmeyers@chainguard.dev>
@jspeed-meyers jspeed-meyers added the enhancement New feature or request label Feb 12, 2023
@jspeed-meyers jspeed-meyers self-assigned this Feb 12, 2023
@jspeed-meyers jspeed-meyers changed the title Replace click with argparse (WIP) Replace click with argparse Feb 12, 2023
@jspeed-meyers jspeed-meyers marked this pull request as draft February 12, 2023 14:17
@github-actions
Copy link

github-actions bot commented Feb 12, 2023

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
252 221 88% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: b135639 by action🐍

Signed-off-by: John Speed Meyers <jsmeyers@chainguard.dev>
Signed-off-by: John Speed Meyers <jsmeyers@chainguard.dev>
Signed-off-by: John Speed Meyers <jsmeyers@chainguard.dev>
Signed-off-by: John Speed Meyers <jsmeyers@chainguard.dev>
@jspeed-meyers jspeed-meyers changed the title (WIP) Replace click with argparse Replace click with argparse Feb 12, 2023
@jspeed-meyers jspeed-meyers marked this pull request as ready for review February 12, 2023 18:20
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @jspeed-meyers

@jspeed-meyers
Copy link
Collaborator Author

Thanks, @goneall. @linynjosh -- I'll wait 24 hours to give you a shot to review too. No worries if you can't find the time. I'm just always glad to lean on your Python expertise :)

Copy link
Collaborator

@yong-aan yong-aan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
Thanks, @jspeed-meyers!

@jspeed-meyers
Copy link
Collaborator Author

Thanks, @linynjosh!

@jspeed-meyers jspeed-meyers merged commit ffb84df into main Feb 13, 2023
@jspeed-meyers jspeed-meyers deleted the remove_click branch February 13, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Click as Dependency, Replace with a Standard Library CLI
3 participants