-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix logic to not allow empty values #88
Conversation
Signed-off-by: John Speed Meyers <jsmeyers@chainguard.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of my few Python specific recommendations - @jspeed-meyers do review the stack-overflow article to make sure my suggestion is valid.
Will also fix linting errors. |
Signed-off-by: John Speed Meyers <jsmeyers@chainguard.dev>
Signed-off-by: John Speed Meyers <jsmeyers@chainguard.dev>
Signed-off-by: John Speed Meyers <jsmeyers@chainguard.dev>
Signed-off-by: John Speed Meyers <jsmeyers@chainguard.dev>
@goneall -- Okay, this is take 2.5 Thank you for the helpful, constructive feedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks @jspeed-meyers
Fix #87