Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add licenseListVersion to LicenseExpression #481
Add licenseListVersion to LicenseExpression #481
Changes from 2 commits
848b8af
03d6eb7
07c57c6
5d6953d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know I'm opening a new topic, but should we be using
/Core/SemVer
like the specVersion? @swinslow , what do you think?Totally fine with ignoring this for now and resolving it later in another issue, if it will add delay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's leave it as is for now. Would making it
/Core/SemVer
less "simple"?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say future issue (as in "far future"). I think we've always used Major.Minor versioning for the license list and I don't know of any current reason to change it to Major.Minor.Patch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, we used to use SPDX x.y for the spec number till now and we moved to SemVer; it might be ok to do the same here.
If not, we have to add a pattern for the valid values of this string, i.e making sure they match x.y -- and I think we have said that even single instances of patterns should be separate custom datatypes. Definitely more complicated.
But as I said, this might be a different issue and this can be merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @zvr that using SemVer would be simpler than creating a different datatype.
@swinslow - if you're OK with the change, I'll update this PR. If not or if you're not sure, I'll merge this and we can open a separate PR to make progress.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@goneall I'm fine with switching to SemVer if you're okay with it. I'm just conscious that it likely means changes to the License List Publisher so I didn't want to commit to it if you have qualms about it!
For the time being I don't expect we'd do anything other than x.y.0 releases, so maybe it's not that big of a deal in any case. But yes, I'm fine with it if you both are good with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @swinslow for the quick reply - I committed a change to use
/Core/SemVer
@zvr - if you could take one more look and approve, I can merge