Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spacing for better readability. #757

Merged
merged 2 commits into from
May 1, 2024
Merged

Conversation

vargenau
Copy link
Contributor

No description provided.

Signed-off-by: Marc-Etienne Vargenau <marc-etienne.vargenau@nokia.com>
Copy link
Contributor

@kestewart kestewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks better this way.

@kestewart kestewart added this to the 3.0.1 milestone Apr 30, 2024
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goneall
Copy link
Member

goneall commented Apr 30, 2024

@vargenau - if you could resolve the merge conflicts, I can merge this in

@bact
Copy link
Contributor

bact commented Apr 30, 2024

Already fixed by #723

The issue with one long paragraph in https://spdx.github.io/spdx-spec/v3.0/model/Core/Classes/NamespaceMap/ comes from the fact that the ordered list:

  1. Use 1) 2) 3) instead of 1. 2. 3.
  2. Use 3 spaces for indent

This is already fixed in main. See NamespaceMap.md

Spacing issue in https://spdx.github.io/spdx-spec/v3.0/model/Core/Properties/dataLicense/ is also got fixed.
See dataLicense

@kestewart
Copy link
Contributor

Ok, I took a pass at fixing the conflicts. Hopefully it's ok. If not, we'll do a new PR. Merging this.

@kestewart kestewart merged commit f167edb into spdx:main May 1, 2024
1 check passed
@bact
Copy link
Contributor

bact commented May 1, 2024

Please see #760 for the fix for 1. vs 1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants