-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use local cache for licenses #117
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry it took me a couple days to take a look.
I think it looks good to me - I think I'll wait a couple days to approve it if that's ok in case @goneall wants to take a look
import org.spdx.storage.listedlicense.SpdxListedLicenseModelStore; | ||
|
||
/** | ||
* @author Gary O'Neall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @goneall
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, this is cause this file was just copied from the spdx-java-library project, so kept the original author intact
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe I should add a note to this comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated the comment
Also, thanks! |
Signed-off-by: Appu Goundan <appu@google.com>
6a79773
to
6844c02
Compare
This embeds the full license data in the plugin.
fixes #16
There is a README.md embedded in the standard_licenses resource directory. But most of the other files are just straight up copied from spdx-license release