Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use local cache for licenses #117

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Use local cache for licenses #117

merged 1 commit into from
Mar 11, 2024

Conversation

loosebazooka
Copy link
Collaborator

@loosebazooka loosebazooka commented Mar 5, 2024

This embeds the full license data in the plugin.

fixes #16

There is a README.md embedded in the standard_licenses resource directory. But most of the other files are just straight up copied from spdx-license release

Copy link
Collaborator

@mathjeff mathjeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took me a couple days to take a look.

I think it looks good to me - I think I'll wait a couple days to approve it if that's ok in case @goneall wants to take a look

import org.spdx.storage.listedlicense.SpdxListedLicenseModelStore;

/**
* @author Gary O'Neall
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this is cause this file was just copied from the spdx-java-library project, so kept the original author intact

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe I should add a note to this comment

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the comment

@mathjeff
Copy link
Collaborator

mathjeff commented Mar 7, 2024

Also, thanks!

Signed-off-by: Appu Goundan <appu@google.com>
@loosebazooka loosebazooka merged commit 9315e87 into main Mar 11, 2024
1 check passed
@loosebazooka loosebazooka deleted the offline-licenses branch March 11, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SPDXParser.OnlyUseLocalLicenses=true by default
2 participants