Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Maven convention for list content #101

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Conversation

hboutemy
Copy link
Contributor

@hboutemy hboutemy commented Jul 4, 2023

while it is true that a goal parameter with list can use any XML element name, the convention is to use the singular of the parameter name: for a excludedFilePatterns parameter for example, param works but excludedFilePattern is what convention expects

Signed-off-by: Hervé Boutemy <hboutemy@apache.org>
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hboutemy - I'm learning a lot about the Maven conventions

@goneall goneall merged commit 2a23cf2 into spdx:master Jul 5, 2023
2 checks passed
@hboutemy hboutemy deleted the patch-1 branch July 6, 2023 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants