Update versions from packages themselves #437
Conversation
Use the Java tools and NTIA Conformance checker package themselves to obtain their version for the About page instead of hard coding. Signed-off-by: Hirumal Priyashan <hirupriyashanrc@gmail.com>
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
src/src/version.py
Outdated
| string -- JAVA Tools version | ||
| """ | ||
| path = join(dirname(abspath(__file__)), "..", jarName) | ||
| output = run(["java", "-jar", path, "Version"], stdout=PIPE).stdout.decode("utf-8") |
There was a problem hiding this comment.
B607: Starting a process with a partial executable path
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Help us improve LIFT! (Sonatype LiftBot external survey)
Was this a good recommendation for you? Answering this survey will not impact your Lift settings.
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
src/src/version.py
Outdated
| string -- JAVA Tools version | ||
| """ | ||
| path = join(dirname(abspath(__file__)), "..", jarName) | ||
| output = run(["java", "-jar", path, "Version"], stdout=PIPE).stdout.decode("utf-8") |
There was a problem hiding this comment.
B603: subprocess call - check for execution of untrusted input.
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Help us improve LIFT! (Sonatype LiftBot external survey)
Was this a good recommendation for you? Answering this survey will not impact your Lift settings.
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
There was a problem hiding this comment.
Thanks @HirumalPriyashan - Overall looks good. Just one suggested UI related change.
Signed-off-by: Hirumal Priyashan <hirupriyashanrc@gmail.com>
Use the Java tools and NTIA Conformance checker package themselves to obtain their version for the About page instead of hard coding.