Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static generated files #524

Merged
merged 1 commit into from
Jan 20, 2024
Merged

Add static generated files #524

merged 1 commit into from
Jan 20, 2024

Conversation

goneall
Copy link
Member

@goneall goneall commented Jan 19, 2024

I'm not sure if these files should be added to the repo.

If not, we should modify the .gitignore file so they will be ignored.

These were generated when testing out the latest build using dockerfile.dev.

@BassCoder2808 @rtgdk - thoughts?

Signed-off-by: Gary O'Neall <gary@sourceauditor.com>
@BassCoder2808
Copy link
Contributor

Hi @goneall, I think yes we should add these files as they are static content, but it can be skipped as well and in README.md we can add the collect static command if somebody wants to run or test it

@goneall goneall marked this pull request as ready for review January 20, 2024 18:04
@goneall
Copy link
Member Author

goneall commented Jan 20, 2024

Thanks @BassCoder2808 - I'll go ahead and merge this in

@goneall goneall merged commit d633c04 into main Jan 20, 2024
@goneall goneall deleted the gendstaticfiles branch January 20, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants