Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in ReleaseDate, BuiltDate, and ValidUntilDate as optional fields #709

Merged
merged 2 commits into from
Jun 12, 2022

Conversation

kestewart
Copy link
Contributor

These fields will be in the Usage Profile in SPDX 3.0, however there is a need for them today to support some of the SBOM use cases. In particular the FDA guidance is asking for an "End of Support" date, which the ValidUntilDate will satisfy. Moving these into a 2.3 specific pull request.

Signed-off-by: Kate Stewart kate.stewart@att.net

These fields will be in the Usage Profile in SPDX 3.0, however there is a need for them today to support some of the SBOM use cases.    In particular the FDA guidance is asking for an "End of Support" date,  which the ValidUntilDate will satisfy.    Moving these into a 2.3 specific pull request.

Signed-off-by: Kate Stewart <kate.stewart@att.net>
@kestewart kestewart added this to the 2.3 milestone Jun 7, 2022
@kestewart
Copy link
Contributor Author

@yoshi-i, could you please review that I have summarized the right information from #671. If you are ok with this version, can you add in your "Signed-off-by:" to this thread.

fix copy/paste errors
@goneall
Copy link
Member

goneall commented Jun 7, 2022

@kestewart Are there any other tags for packages or files that are not prefixed by Package or File? If these are the first such non-specific tags to be introduced, it may require a significant redesign of the Java Tag/Value parser and other parsers as well. I'll need to review the code to confirm.

Copy link
Contributor

@seabass-labrax seabass-labrax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections to this being merged except for my comment about naming below. 😃

chapters/package-information.md Show resolved Hide resolved
@goneall
Copy link
Member

goneall commented Jun 8, 2022

Are there any other tags for packages or files that are not prefixed by Package or File? If these are the first such non-specific tags to be introduced, it may require a significant redesign of the Java Tag/Value parser and other parsers as well. I'll need to review the code to confirm.

@kestewart I did some research on the parsers and there is no issue with the naming as proposed as long as we don't use the same property name for a file. The current proposal is just for packages, so we are fine. I do like the current naming proposal since it is compatible with the JSON and RDF notations.

@goneall
Copy link
Member

goneall commented Jun 8, 2022

@kestewart - Please add the DCO sign-off

@kestewart
Copy link
Contributor Author

@goneall - hand holding please - I tried to add it (see initial comment), but something in my config needs to be updated it seems.

@yoshi-i
Copy link

yoshi-i commented Jun 9, 2022

Hello @kestewart -san, I reviewed your commits and discussed about it with @NorioKobota -san. I agree with your summarized proposal and I will gladly add "Signed-off-by:" to this comment.

If it need to other explicit commit action with signed-off-by field or other operation to package-information.md on specific branch, please let me know.

Signed-off-by: Yoshiyuki Ito yoshiyuki.ito.ub@renesas.com

@kestewart
Copy link
Contributor Author

@goneall, please review and merge if you're ok with the explanation provided.

@seabass-labrax
Copy link
Contributor

seabass-labrax commented Jun 11, 2022 via email

@goneall goneall merged commit f02a97f into development/v2.3 Jun 12, 2022
@goneall goneall deleted the kestewart-usage-info branch June 12, 2022 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants