Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Package Purpose to Primary Package Purpose #721

Merged
merged 1 commit into from Jun 22, 2022
Merged

Conversation

goneall
Copy link
Member

@goneall goneall commented Jun 16, 2022

Fixes #720

Signed-off-by: Gary O'Neall gary@sourceauditor.com

Fixes #720

Signed-off-by: Gary O'Neall <gary@sourceauditor.com>
@goneall goneall added this to the 2.3 milestone Jun 16, 2022
@goneall
Copy link
Member Author

goneall commented Jun 16, 2022

@nishakm - let me know if this looks good to you - see issue #720 for context.

@rjb4standards
Copy link

REA supports this proposed change to use Primary Package Purpose with a cardinality of 0..1, with content constrained to one of the enumerated set of valid options specified for SPDX Version 2.3.

Copy link
Contributor

@kestewart kestewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change makes sense to me.

+1 on merging.

@goneall goneall merged commit 517c92f into development/v2.3 Jun 22, 2022
@goneall goneall deleted the purpose branch June 22, 2022 18:20
goneall added a commit that referenced this pull request Jun 22, 2022
Updates the schema to match spec changes from PR #721
Also updates the licenseId description based on review
comments.

Signed-off-by: Gary O'Neall <gary@sourceauditor.com>
goneall added a commit that referenced this pull request Jun 23, 2022
Updates the schema to match spec changes from PR #721
Also updates the licenseId description based on review
comments.

Signed-off-by: Gary O'Neall <gary@sourceauditor.com>
@rnjudge
Copy link
Contributor

rnjudge commented Jun 27, 2022

@goneall what would this field be called in the JSON format? primaryPackagePurpose? or just primaryPurpose?

@goneall
Copy link
Member Author

goneall commented Jun 28, 2022

what would this field be called in the JSON format? primaryPackagePurpose? or just primaryPurpose?

@rnjudge primaryPackagePurpose - consistent with the RDF property name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should packagePurpose have cardinality 0..1?
5 participants