Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New workflow for deploying the v3 spec to the site. #874

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

licquia
Copy link
Collaborator

@licquia licquia commented Jan 29, 2024

This workflow uses spec-parser and spdx-3-model to build and deploy the v3 spec into the main spec site, alongside the 2.x versions already deployed.

It is designed to be triggered by pushes to the development/v3.0 branch, via manual triggers, and via external triggers. The latter can be used to build workflows to cause the spec to be rebuilt on changes to spec-parser or spdx-3-model.

This workflow uses spec-parser and spdx-3-model to build and deploy
the v3 spec into the main spec site, alongside the 2.x versions
already deployed.

It is designed to be triggered by pushes to the development/v3.0
branch, via manual triggers, and via external triggers.  The latter
can be used to build workflows to cause the spec to be rebuilt on
changes to spec-parser or spdx-3-model.

Signed-off-by: Jeff Licquia <jeff@licquia.org>
@licquia licquia requested review from zvr and goneall January 29, 2024 02:22
@licquia
Copy link
Collaborator Author

licquia commented Jan 29, 2024

Additional notes:

The new workflow will add the 3.0 spec to the dropdown on the main spec page (https://spdx.github.io/spdx-spec/). I was able to test the workflow manually on my system, and it successfully added the 3.0 spec alongside the others.

Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @licquia - I have to admit, I may not be the best reviewer of actions, but it looks good to me.

If no one finds any issues before Tuesday, I'll merge

@kestewart
Copy link
Contributor

Thanks Jeff, I'm not qualified to review the workflow, but from the comments, it seems like a good path. I added @iamwillbar to the thread in case he has a chance to take a look.

@goneall
Copy link
Member

goneall commented Jan 31, 2024

No one objected, so I'll go ahead and merge this in

@goneall goneall merged commit 5d80ac2 into development/v3.0 Jan 31, 2024
2 checks passed
@goneall goneall deleted the v3_workflow branch January 31, 2024 10:40
@goneall
Copy link
Member

goneall commented Jan 31, 2024

@licquia - I just got a rather strange error from github actions after merging this. Any thoughts?

Run actions/checkout@f43a0e5ff[2](https://github.com/spdx/spdx-spec/actions/runs/7724789092/job/21057629430#step:3:2)bd2940956[3](https://github.com/spdx/spdx-spec/actions/runs/7724789092/job/21057629430#step:3:3)8e18286ca9a3d19567[4](https://github.com/spdx/spdx-spec/actions/runs/7724789092/job/21057629430#step:3:4)4
  with:
    ref: development/v3.0
    path: spdx-spec
    fetch-depth: 0
    token: ***
  
    repository: spdx/spdx-spec
    ssh-strict: true
    persist-credentials: true
    clean: true
    sparse-checkout-cone-mode: true
    fetch-tags: false
    lfs: false
    submodules: false
    set-safe-directory: true
/usr/bin/docker exec  1cd7e64fd[5](https://github.com/spdx/spdx-spec/actions/runs/7724789092/job/21057629430#step:3:5)b729adfea915e7545838e904c38b1[6](https://github.com/spdx/spdx-spec/actions/runs/7724789092/job/21057629430#step:3:6)f1dc80a9fc911cb3[7](https://github.com/spdx/spdx-spec/actions/runs/7724789092/job/21057629430#step:3:7)675d6bc sh -c "cat /etc/*release | grep ^ID"
Syncing repository: spdx/spdx-spec
Getting Git version info
Temporarily overriding HOME='/__w/_temp/29e[8](https://github.com/spdx/spdx-spec/actions/runs/7724789092/job/21057629430#step:3:8)2a5d-1bdd-41ab-8031-cbf3c37253b[9](https://github.com/spdx/spdx-spec/actions/runs/7724789092/job/21057629430#step:3:9)' before making global git config changes
Adding repository directory to the temporary git global config as a safe directory
/usr/bin/git config --global --add safe.directory /__w/spdx-spec/spdx-spec/spdx-spec
Initializing the repository
Disabling automatic garbage collection
Setting up auth
Fetching the repository
  /usr/bin/git -c protocol.version=2 fetch --prune --progress --no-recurse-submodules origin +refs/heads/*:refs/remotes/origin/* +refs/tags/*:refs/tags/*
  Error: fatal: could not read Username for 'https://github.com': terminal prompts disabled
  The process '/usr/bin/git' failed with exit code [12](https://github.com/spdx/spdx-spec/actions/runs/7724789092/job/21057629430#step:3:12)8
  Waiting 18 seconds before trying again
  /usr/bin/git -c protocol.version=2 fetch --prune --progress --no-recurse-submodules origin +refs/heads/*:refs/remotes/origin/* +refs/tags/*:refs/tags/*
  Error: fatal: could not read Username for 'https://github.com': terminal prompts disabled
  The process '/usr/bin/git' failed with exit code 128
  Waiting [15](https://github.com/spdx/spdx-spec/actions/runs/7724789092/job/21057629430#step:3:15) seconds before trying again
  /usr/bin/git -c protocol.version=2 fetch --prune --progress --no-recurse-submodules origin +refs/heads/*:refs/remotes/origin/* +refs/tags/*:refs/tags/*
  Error: fatal: could not read Username for 'https://github.com/': terminal prompts disabled
  Error: The process '/usr/bin/git' failed with exit code 128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants