Sync the model diagrams with the model repo #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kestewart
requested changes
Feb 18, 2024
There was a problem hiding this comment.
Double check, this is looking like the core, not security. Also, is this reducnant with model Security.png.
There was a problem hiding this comment.
Removed the extra image.
I noticed this too while on the plane.
The image is present in the model repo - it is stale compared to model Security.png.
BTW - The image was not used in the website or PDF.
goneall
force-pushed
the
sync-diagrams
branch
from
ddbbc6e
to
4da109c
Compare
Signed-off-by: Gary O'Neall <gary@sourceauditor.com>
Signed-off-by: Gary O'Neall <gary@sourceauditor.com>
goneall
force-pushed
the
sync-diagrams
branch
from
4da109c
to
166a925
Compare
|
Resolved @kestewart feedback, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the diagrams with the model repo after merging spdx/spdx-3-model#643