Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ABNF for license expressions #960

Merged
merged 2 commits into from
May 28, 2024
Merged

Conversation

zvr
Copy link
Member

@zvr zvr commented May 9, 2024

In the license expressions expressed in ABNF form, make explicit that strings (like "AND" and "and") are case-sensitive. This was expressed in the text below, but not in the grammar.

Fixes #922

Signed-off-by: Alexios Zavras <github@zvr.gr>
@zvr zvr added this to the 3.0.1 milestone May 9, 2024
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kestewart kestewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this should help with the generation.

@goneall goneall merged commit 151cd0f into spdx:development/v3.0.1 May 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ABNF grammar of Annex D and case-sensitivity
3 participants