Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

annexes: getting started: Fix SPDX IDs #964

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

JPEWdev
Copy link
Contributor

@JPEWdev JPEWdev commented May 21, 2024

The SPDX IDs used in the example are fabricated, but not good examples to follow for users trying understand how to write their own documents. Fix this by using the "https://spdx.org/spdxdocs/" prefix and using a UUID at the end

The SPDX IDs used in the example are fabricated, but not good examples
to follow for users trying understand how to write their own documents.
Fix this by using the "https://spdx.org/spdxdocs/" prefix and using a
UUID at the end

Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

BTW if / when we support the namespacing of SPDX ID's we may be able to make these a bit more readable by having the GUID in a common prefix.

@zvr
Copy link
Member

zvr commented May 23, 2024

In JSON level they are just strings.

Instead of

            "spdxId": "https://spdx.org/spdxdocs/File-8f79956e-4089-4166-9a71-457de77e4846",

you can already easily write

            "spdxId": "mydata:File-8f79956e-4089-4166-9a71-457de77e4846",

by having a @context defining your mydata prefix.

Or am I missing something?

@zvr
Copy link
Member

zvr commented May 23, 2024

Re: the actual PR, I'd actually prefer if the IDs were not on spdx.org but on another domain. We don't want to give the impression that spdx.org/spdxdocs is something special and should always be used...

@JPEWdev
Copy link
Contributor Author

JPEWdev commented May 23, 2024 via email

@JPEWdev
Copy link
Contributor Author

JPEWdev commented May 23, 2024 via email

@goneall goneall merged commit c647306 into spdx:development/v3.0.1 Jun 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants