YAML documentation and JSON documentation fixes #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianling
reviewed
May 4, 2022
| args := os.Args | ||
| if len(args) != 3 { | ||
| fmt.Printf("Usage: %v <yaml-file-in> <spdx-file-out>\n", args[0]) | ||
| fmt.Printf(" Load SPDX 2.2 tag-value file <yaml-file-in>, and\n") |
There was a problem hiding this comment.
Thanks, I changed
ianling
reviewed
May 4, 2022
| defer w.Close() | ||
|
|
||
| // try to save the document to disk as an SPDX tag-value file, version 2.2 | ||
| err = spdx_yaml.Save2_2(doc, w) |
There was a problem hiding this comment.
Saves a YAML file, not tag-value
There was a problem hiding this comment.
Thanks, I changed
|
There might be more small nitpicky typos, I didn't seek them all out, but looks good 😃 thanks for adding examples |
Signed-off-by: Steve Winslow <steve@swinslow.net> Signed-off-by: CatalinStratu <catalinstratu45@gmail.com>
Signed-off-by: Steve Winslow <steve@swinslow.net> Signed-off-by: CatalinStratu <catalinstratu45@gmail.com>
Signed-off-by: Steve Winslow <steve@swinslow.net> Signed-off-by: CatalinStratu <catalinstratu45@gmail.com>
Signed-off-by: Ian Ling <ian@iancaling.com> Signed-off-by: CatalinStratu <catalinstratu45@gmail.com>
Signed-off-by: Ian Ling <ian@iancaling.com> Signed-off-by: CatalinStratu <catalinstratu45@gmail.com>
Signed-off-by: CatalinStratu <catalinstratu45@gmail.com>
Signed-off-by: CatalinStratu <catalinstratu45@gmail.com>
Signed-off-by: CatalinStratu <catalinstratu45@gmail.com>
Signed-off-by: CatalinStratu <catalinstratu45@gmail.com>
Signed-off-by: CatalinStratu <catalinstratu45@gmail.com>
Signed-off-by: CatalinStratu <catalinstratu45@gmail.com>
Signed-off-by: CatalinStratu <catalinstratu45@gmail.com>
ianling
approved these changes
May 5, 2022
|
Hi, @swinslow what do you think about this PR? |
swinslow
approved these changes
May 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, in this PR I added the example of using the YAML component and small fixes to the example of using the JSON component. Thank you!