[issue-442] change CLI to read version from document #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also print validation output to stderr Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
meretp
approved these changes
Jan 26, 2023
There was a problem hiding this comment.
Looks good to me, only one (resp. two) additions from my side.
Looking at the changes I was wondering what happens if the parsed document doesn't have a version. From our implementation the parser would throw a SPDXParsingError whenever required fields are missing and maybe we also want to catch this to not print the whole stacktrace. What do you think?
src/spdx/clitools/pyspdxtools.py
Outdated
| @@ -26,7 +26,7 @@ | |||
| @click.command() | |||
| @click.option("--infile", "-i", prompt="input file path", help="The file containing the document to be validated or converted.") | |||
There was a problem hiding this comment.
Could you please also delete the prompt? I think we can do both of these changes within one PR that touches CLI.
Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
|
SPDXParsingErrors are excepted now :) |
|
Perfect, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also print validation output to stderr
fixes #442
Signed-off-by: Armin Tänzer armin.taenzer@tngtech.com