Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue-10] use license_expression library for LicenseExpression #447

Merged

Conversation

armintaenzertng
Copy link
Collaborator

@armintaenzertng armintaenzertng commented Jan 26, 2023

Note: LicenseExpression instances can not be evaluated to bool, so statements like if license_expression: don't work anymore.

fixes #10

Signed-off-by: Armin Tänzer armin.taenzer@tngtech.com

Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
Copy link
Collaborator

@meretp meretp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this long open issue!
I have found a few minor errors, we should add tests for these.

src/spdx/parser/jsonlikedict/license_expression_parser.py Outdated Show resolved Hide resolved
src/spdx/writer/tagvalue/snippet_writer.py Outdated Show resolved Hide resolved
src/spdx/writer/tagvalue/package_writer.py Outdated Show resolved Hide resolved
src/spdx/writer/tagvalue/file_writer.py Outdated Show resolved Hide resolved
as they are already caught by append_parsed_field_or_log_error

Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
to handle lists of licenses with NONE and NOASSERTION values

Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
Copy link
Collaborator

@meretp meretp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

@armintaenzertng armintaenzertng merged commit b1cd78c into spdx:refactor-python-tools Jan 27, 2023
@armintaenzertng armintaenzertng deleted the licenseExpressions branch January 27, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants