Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue-593] expose model classes in model package init #597

Merged
merged 1 commit into from Apr 19, 2023

Conversation

armintaenzertng
Copy link
Collaborator

I had to exclude the __init__.py from isort and flake8 because the order of the imports matters in that case.

part of #593

Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
Copy link
Collaborator

@meretp meretp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think this is real improvement concerning readability. I was wondering if we might want to use this for other classes outside of spdx_tools.spdx.model, for example the parser class in spdx_tools.spdx.parser.jsonlikedict, what do you think?

@armintaenzertng
Copy link
Collaborator Author

I also think that this approach can be applied to other packages as well, but it probably has the most impact for the model package, as that is the one that will be most widely used by users, I imagine.

@armintaenzertng armintaenzertng merged commit 8d7d7b7 into spdx:main Apr 19, 2023
32 checks passed
@armintaenzertng armintaenzertng deleted the adaptModelImports branch April 19, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants