[issue-722] add calculate_package_verification_code()
#723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems that Windows yields different results when using Edit: This was due to |
armintaenzertng
force-pushed
the
addVerificationCodeCalculator
branch
2 times, most recently
from
ca98d6c
to
be46a07
Compare
fholger
requested changes
Jul 11, 2023
|
|
||
| with pytest.raises(FileNotFoundError) as err: | ||
| calculate_package_verification_code([file1]) | ||
| assert unknown_file_name in err.value |
There was a problem hiding this comment.
This line is never reached, you need to unindent it one level.
You also have to explicitly convert the error to string, otherwise this assertion fails, i.e. str(err.value)
There was a problem hiding this comment.
Thanks! :)
|
|
||
| def calculate_package_verification_code(files: List[File]) -> str: | ||
| list_of_file_hashes = [] | ||
| hash_algorithm_name = ChecksumAlgorithm.SHA1 |
There was a problem hiding this comment.
Shouldn't this be a parameter to the function and then consequently used below wherever SHA1 is explicitly mentioned? Or is there a reason we only want to support SHA1 here?
also add calculate_file_checksum(), as this is needed by the package verification code Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
armintaenzertng
force-pushed
the
addVerificationCodeCalculator
branch
from
be46a07
to
f9efcac
Compare
fholger
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also add
calculate_file_checksum(), as this is needed by the package verification codefixes #722