Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting of plain license text in JSON data is broken #162

Closed
sschuberth opened this issue Jun 11, 2018 · 2 comments
Closed

Formatting of plain license text in JSON data is broken #162

sschuberth opened this issue Jun 11, 2018 · 2 comments

Comments

@sschuberth
Copy link
Member

At the example of Apache-2.0, when extracting the licenseText string to a file, I'd expect that file to be exactly formatted like the original plain text license including leading spaces and blank lines. However, the JSON string is formatted like

Apache License

Version 2.0, January 2004

http://www.apache.org/licenses/ TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION

   1. Definitions.

      

      "License" shall mean the terms and conditions for use, reproduction, and distribution as defined by Sections 1 through 9 of this document.

      

      "Licensor" shall mean the copyright owner or entity authorized by the copyright owner that is granting the License.

      

(note the missing leading spaces but added trailing spaces) which not only does not match the original text but also is quite ugly.

@goneall
Copy link
Member

goneall commented Jun 11, 2018

The way we are maintaining the license information in the license-list-XML github repository it is not feasible to retain the formatting of the original text since XML removes the white space and we do not have enough tags to retain all of the formatting.

That being said, we could do a better job of formatting the text and making it look prettier.

The code for this has actually moved to a different project: LicenseListPublish

@goneall
Copy link
Member

goneall commented Jun 11, 2018

Moving issue to LicenseListPublisher: spdx/license-list-XML#1924

@goneall goneall closed this as completed Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants