response: set .finished to true on .end()

Fix: #276
spdy-http2 · Sep 19, 2016 · a583cf6 · a583cf6
1 parent 7524b4e
commit a583cf6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/lib/spdy/response.js b/lib/spdy/response.js
@@ -67,6 +67,9 @@ exports.end = function end(data, encoding, callback) {
   if (!this.socket._handle)
     return;
 
+  // Compatibility with Node.js core
+  this.finished = true;
+
   var self = this;
   var handle = this.socket._handle;
   handle._spdyState.ending = true;

diff --git a/test/server-test.js b/test/server-test.js
@@ -88,6 +88,7 @@ describe('SPDY Server', function() {
             ok: 'yes'
           });
           res.end('response');
+          assert(res.finished, 'res.finished should be set');
         });
         req.resume();
       });