Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use gen.yaml structure for config metadata #4

Merged
merged 2 commits into from
Mar 27, 2023

Conversation

anuraagnalluri
Copy link
Contributor

No description provided.

@linear
Copy link

linear bot commented Mar 24, 2023

SPE-1295 Make rest of gen.yaml config options and workflow file options "data-driven"

Currently, the language-specific fields for SDK config in the UI are pulled directly from the openapi generation (such as here). The purpose of that is to keep the config options in the UI always up to date with what is expected by the generator

However, there are still many configuration options in gen.yaml and the action that are not configurable via the UI. Some noteable examples include SdkClassName (gen.yaml) and PR mode (workflow file). We should resolve that by making those configs "data driven" in the same way the language config fields are

@anuraagnalluri anuraagnalluri marked this pull request as ready for review March 25, 2023 01:20
@anuraagnalluri anuraagnalluri changed the title [WIP] fix: use gen.yaml structure for config metadata fix: use gen.yaml structure for config metadata Mar 25, 2023
@anuraagnalluri anuraagnalluri merged commit 679aaa3 into main Mar 27, 2023
@anuraagnalluri anuraagnalluri deleted the feature/spe-1295 branch March 27, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant