feat: autoconfigure github repos #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -499,6 +503,39 @@ func configureGithub(ctx context.Context, _flags ConfigureGithubFlags) error { | |||
|
|
|||
| ctx = events.SetTargetInContext(ctx, workingDir) | |||
|
|
|||
| // check if the git repository is a github URI | |||
| event := shared.CliEvent{} | |||
| events.EnrichEventWithGitMetadata(ctx, &event) | |||
There was a problem hiding this comment.
nit: I feel like this is a bit of a hack. Can we just expose a method like GetGitMetadata that is used both inside EnrichEvent and here?
There was a problem hiding this comment.
Ya I was just trying to not change it in core, I can do that
|
|
||
| if continueAfterInstall { | ||
| browser.OpenURL(appInstallURL) | ||
| logger.Println(styles.Info.Render("Install the Github App then continue with `speakeasy configure github`!\n")) |
There was a problem hiding this comment.
Can we not wait until we detect its installed, then continue?
There was a problem hiding this comment.
We could poll. But I'm not sure that's the best idea.
- We don't know what kind of caching github has in place
- Sometimes a user may not have the right permissions to install it by themselves.
Polling just felt kind of weird to me
chase-crumbaugh
approved these changes
May 21, 2024
…ate_github_app_prompts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If speakeasy configure github is called from a directory with a remote default we