Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create otpauth URL with issuer parameter in generateSecret() function #70

Closed
wants to merge 6 commits into from
Closed

Create otpauth URL with issuer parameter in generateSecret() function #70

wants to merge 6 commits into from

Conversation

railsstudent
Copy link
Collaborator

Related to #69

@coveralls
Copy link

coveralls commented Jan 17, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 5ec7c70 on railsstudent:master into 09a7511 on speakeasyjs:master.

mikepb
mikepb reviewed Jan 17, 2017
View reviewed changes
README.md
@@ -294,7 +294,7 @@ How this works:
// Set ASCII secret
var secret = 'rNONHRni6BAk7y2TiKrv';

// Get HOTP counter token at counter = 42
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These superficial white space changes slow down the review process. I was thinking we could reformat the library using https://github.com/feross/standard in one commit and get it over with. Could you omit these whitespace changes for this commit?

@coveralls
Copy link

coveralls commented Jan 17, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 3761613 on railsstudent:master into 09a7511 on speakeasyjs:master.

@coveralls
Copy link

coveralls commented Jan 17, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 8c8624e on railsstudent:master into 09a7511 on speakeasyjs:master.

@railsstudent
Copy link
Collaborator Author

I added the trailing whitespace back. I will be attentive to whitespace issue in the future.

@coveralls
Copy link

coveralls commented Jan 17, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 6d9fddc on railsstudent:master into 09a7511 on speakeasyjs:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 6d9fddc on railsstudent:master into 09a7511 on speakeasyjs:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 6d9fddc on railsstudent:master into 09a7511 on speakeasyjs:master.

@railsstudent
Make the documentation of otpAuthURL consistent with code.
99f2f71 
algorithm. period, digit has no default value
default value of encoding is set to ascii
@coveralls
Copy link

coveralls commented Jan 17, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 99f2f71 on railsstudent:master into 09a7511 on speakeasyjs:master.

@coveralls
Copy link

coveralls commented Jan 17, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling a6f312f on railsstudent:master into 09a7511 on speakeasyjs:master.

@railsstudent
Copy link
Collaborator Author

#71
Sorry. changes in my master branch are also synchronize to this PR.

@mikepb
Copy link
Collaborator

mikepb commented Jan 18, 2017 via email

@railsstudent
Copy link
Collaborator Author

I will close this PR, work on separate branches and make 2 PRs tonight.

@railsstudent railsstudent mentioned this pull request Jan 18, 2017
Merged
@mikepb mikepb added this to Pull Requests in 3.0 Feb 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikepb mikepb mikepb left review comments

Assignees
No one assigned
Labels
None yet
Projects
3.0
Pull Requests
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@railsstudent @coveralls @mikepb