Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default values of otpAuthURL are inconsistent with the documentation in README.md #71

Closed
railsstudent opened this issue Jan 17, 2017 · 3 comments

Comments

@railsstudent
Copy link
Collaborator

In README.md, the default values of algorithm, digits, period are sha1, 6 and 30 respectively. In code, no value is assigned and it works in google authenticator app for now because these parameters are ignored.

In code, the default value of encoding is ascii but README.md leaves the default value blank,
I would like to make the doc and code consistent, so the code does what the documentation says.

@markbao
Copy link
Collaborator

markbao commented Feb 28, 2017

@railsstudent, PR #74 resolves this, correct?

Sharp eye - thanks for being on top of this.

@railsstudent
Copy link
Collaborator Author

yes. #74 resolves this.

@mikepb
Copy link
Collaborator

mikepb commented Feb 28, 2017

Closing as resolved.

@mikepb mikepb closed this as completed Feb 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants