Starlette support #1431
Starlette support #1431
Conversation
|
This is still rough around the edges, but would welcome a first review |
|
Any progress on this? |
| ) | ||
| endpoint_name = f"{self._api_name}_not_found" | ||
| self.subapp.add_route( | ||
| path="/{not_found_path}", |
There was a problem hiding this comment.
What is the intention here? Shouldn't we be using exception handlers?
There was a problem hiding this comment.
I tried to diverge as little as possible from the aiohttp implementation, but this can be changed. Will look at it tomorrow
Co-authored-by: Rafael Carício <rafael@caricio.com>
|
Hi @arkkors, Thanks for the PR and sorry for the late response. Unfortunately, we've decided to go for another framework agnostic approach (see #1395 (comment)). I was able to reuse some of your code for this though, so I added you as a co-author to #1496. I hope this is ok for you, let me know if it isn't. |
|
Connexion 3.0 will support ASGI frameworks out of the box (and is now built on top of Starlette). See #1395 |
Fixes #496 .
Changes proposed in this pull request:
uvicornASGI server