set max aiohttp version to 3.5.1 (until build is fixed) #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 9, 2019
Merged
|
👍 |
hjacobs
approved these changes
Jan 10, 2019
10 tasks
cognifloyd
added a commit
to cognifloyd/connexion
that referenced
this pull request
May 22, 2019
…-first#844)" This reverts commit b2a4287.
Merged
hjacobs
pushed a commit
that referenced
this pull request
Oct 15, 2019
* Revert "set max aiohttp version to 3.5.1 (until build is fixed) (#844)" This reverts commit b2a4287. * Fix test_run_with_aiohttp_not_installed Somewhere between 3.5.1 and 3.5.2, the aiohttp reimport started succeeding (in connexion.connexion.cli.run()). It's not clear which change caused the issue, but it's probably one of: - aio-libs/aiohttp#3469 (Remove wildcard imports) - aio-libs/aiohttp#3464 (Don't suppress gunicorn cleanup errors) - aio-libs/aiohttp#3471 (Refactor workers) - aio-libs/aiohttp#3500 (Ignore done tasks) In any case, setting sys.modules['aiohttp'] = None should prevent reimporting it. See: https://stackoverflow.com/a/1350574 I successfully tested locally on py37 with aiohttp 3.5.1 and 3.5.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes master
Master is broken because of an aiohttp update upstream:
https://travis-ci.org/zalando/connexion/builds/469438675
Changes proposed in this pull request:
I want to confirm that this fixes the build, and then we can investigate how to support the newest version.