-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dfn panel changes for linking syntax #2685
Conversation
bikeshed/dfnpanels/dfnpanels.js
Outdated
@@ -226,7 +312,6 @@ | |||
pinDfnPanel(dfnPanel); | |||
} | |||
event.stopPropagation(); | |||
event.preventDefault(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without event.preventDefault(), the page scrolls so that the dfn is at the top of the window, and the dfn panel appears to just disappear, but it is moved simultaneously to the bottom left corner. If that is your intention, fine. I found it confusing, however. I would guess you intend this behavior to make it easy to revisit the dfn by clicking the header link in the previously activated dfn panel. I so, maybe we should think about doing that and more in a better way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hadn't realized that this event.preventDefault() call was also disabling all the other links on the panel. We'll look into fixing the scrolling behavior perhaps a different way.
This PR fixes #1319 |
This PR adds a "Possible linking syntaxe(es)" section to dfn panels.
Here is what it looks like now.