Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draggable query lines are displayed behind the dialog #3279

Closed
maxpatiiuk opened this issue Mar 31, 2023 · 2 comments · Fixed by #3313
Closed

Draggable query lines are displayed behind the dialog #3279

maxpatiiuk opened this issue Mar 31, 2023 · 2 comments · Fixed by #3313
Assignees
Labels
1 - Bug Incorrect behavior of the product
Projects

Comments

@maxpatiiuk
Copy link
Member

See #3272 (comment)
See #3272 (comment)

it is a z-index problem
and it's a bad bug
but we can't fix it in this release because we are supposed to have it released early next week, where as we haven't even merged anything yet
there is trickiness to this:
you need to use z-index higher than a dialog when inside a dialog
you need to use z-index lower than a dialog when outside a dialog, but a dialog is rendered on top (i.e, opened a notifications dialog, and have query builder in the background)
you need to have z-index in between when you have two dialogs
z-index of a dialog increases every time you click on it:

Screen.Recording.2023-03-31.at.09.28.58.mov
@maxpatiiuk maxpatiiuk added the 1 - Bug Incorrect behavior of the product label Mar 31, 2023
@maxpatiiuk maxpatiiuk added this to Unsorted in UI Refactor via automation Mar 31, 2023
@maxpatiiuk
Copy link
Member Author

maxpatiiuk commented Mar 31, 2023

perfect fix would be hard
might be best to read the z-index of the closest container when you start drag, and assign that z-index to the query line

CarolineDenis added a commit that referenced this issue Apr 6, 2023
UI Refactor automation moved this from Unsorted to Shipped Apr 25, 2023
@specifysoftware
Copy link

This issue has been mentioned on Specify Community Forum. There might be relevant details there:

https://discourse.specifysoftware.org/t/specify-7-8-11-release-announcement/1174/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - Bug Incorrect behavior of the product
Projects
UI Refactor
  
Shipped
Development

Successfully merging a pull request may close this issue.

3 participants