Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes query line being behind dialog #3313

Merged
merged 2 commits into from Apr 25, 2023
Merged

Fixes query line being behind dialog #3313

merged 2 commits into from Apr 25, 2023

Conversation

CarolineDenis
Copy link
Contributor

Fixes #3279

To test:

  • start to drag a query line and do not release
  • use tab until you focus close button
  • press enter
  • the dialog should close and the line dragged should disappears

@CarolineDenis CarolineDenis requested review from maxpatiiuk and a team April 6, 2023 18:11
@CarolineDenis @github-actions
Lint code with ESLint and Prettier
d0fb485 
Triggered by c3156c6 on branch refs/heads/issue-3279
maxpatiiuk
maxpatiiuk approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@maxpatiiuk maxpatiiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CarolineDenis can you refactor the code (either here or in a separate PR) to move the sortable code into a separate hook that can be easily reused in multiple places?

chanulee1
chanulee1 approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@chanulee1 chanulee1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dialog closes and dragged query line disappears as per testing instructions. Is there anything else that needs to be tested?

@CarolineDenis CarolineDenis merged commit e96288c into production Apr 25, 2023
8 checks passed
@CarolineDenis CarolineDenis deleted the issue-3279 branch April 25, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxpatiiuk maxpatiiuk maxpatiiuk approved these changes

@chanulee1 chanulee1 chanulee1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Draggable query lines are displayed behind the dialog
3 participants
@CarolineDenis @maxpatiiuk @chanulee1