Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply button color preferences to statistics page save button #3722

Closed
bronwyncombs opened this issue Jul 5, 2023 · 3 comments · Fixed by #3747
Closed

Apply button color preferences to statistics page save button #3722

bronwyncombs opened this issue Jul 5, 2023 · 3 comments · Fixed by #3747
Assignees
Labels
1 - Bug Incorrect behavior of the product 2 - Preferences Issues that are related to preferences 2 - Statistics Issues that are related to the statistics page
Milestone

Comments

@bronwyncombs
Copy link

Describe the Bug
Changing save button color in preferences has no effect on save button in stats page. Currently, the save button is still controlled by 'Secondary button color'.

To Reproduce
Steps to reproduce the behavior:

  1. Go to preferences and change button color
  2. Go to statistics and click edit to show save button
  3. See error

Expected behavior
Secondary button color shouldn't apply to stats save button. Save color should apply to stats save button.

Screenshots
If applicable, add screenshots to help explain your problem.
Screen Shot 2023-07-05 at 11 44 08 AM
Screen Shot 2023-07-05 at 11 43 48 AM

Desktop:

  • OS: macOS
  • Browser: Chrome
  • Specify 7 Version: v7.9-dev

Database Name: If applicable
uoregonpaleo

Additional context
Database name or any other context about the problem here.

@bronwyncombs bronwyncombs added 1 - Bug Incorrect behavior of the product 2 - Preferences Issues that are related to preferences 2 - Statistics Issues that are related to the statistics page labels Jul 5, 2023
@bronwyncombs
Copy link
Author

Let's also unify the save button in the Edit Page dialog. Currently is set as an info button

Screen Shot 2023-07-06 at 2 47 35 PM

@maxpatiiuk
Copy link
Member

Love all these colors!

makes it look like material you:

image

@CarolineDenis CarolineDenis self-assigned this Jul 7, 2023
CarolineDenis added a commit that referenced this issue Jul 7, 2023
@grantfitzsimmons grantfitzsimmons linked a pull request Jul 12, 2023 that will close this issue
@grantfitzsimmons
Copy link
Contributor

Solved by #3747

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - Bug Incorrect behavior of the product 2 - Preferences Issues that are related to preferences 2 - Statistics Issues that are related to the statistics page
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants